-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable buggy LTO #320
Disable buggy LTO #320
Conversation
Thank you for finding the issue so quickly and the new CI test ❤️ Do we want to release v0.4.2 with this patch? In that case, could you update the changelog entry?
Yes of course! I'll add it, once this PR is done with the merge queue. |
Yes, let's do a 0.4.2. Btw. each patch release breaks our CI workflow, which is pinned to a specific I think you'll need to merge this one bypassing the CI status checks because github actions test on windows is going to be red until 0.4.2 is released |
I have no idea what happened there, so I just squashed |
There was also this hang on driver ARM build. I also have no idea what happened there. It could be a bug in rustc or qemu. I just reduced the timeout to 60 minutes. For me the build works fine and finishes within ~11 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, that's another bug down!
Let's get the v0.4.2
party started :D
And the smoke tests have been added to the CI requirements :D |
Fixes marker_rustc_driver crashing on windows with
exit code: 0xc0000005, STATUS_ACCESS_VIOLATION
. Reported in #318 (comment).I disabled LTO, in release build and it fixes the problem.
I extended the CI to perform a really simple release smoke test both for the current release and for the previous release (in github action test CI job).
Here, for example, you may see that the bug reproduces in master on the changed CI
With the disabled LTO
release-smoke-test
passesBtw. @xFrednet could you add the
release-smoke-test
jobs to required ones please?