Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup infrastructure to allow Auxv information to be passed from crashed process. #127

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

marti4d
Copy link
Collaborator

@marti4d marti4d commented Jul 16, 2024

If the crashed process supports it, it can directly pass in the needed values from the auxiliary vector to avoid potential issues where "/proc/{pid}/auxv" can't be accessed on Android.

If the information is not passed in (or is incomplete), the code will attempt to fill in any gaps from the auxv file. If any of this fails, it will now just log a warning message and continue writing the minidump.

Fixes #27

src/linux/auxv/mod.rs Outdated Show resolved Hide resolved
@marti4d marti4d requested a review from Jake-Shadle July 22, 2024 23:33
Copy link
Contributor

@gabrielesvelto gabrielesvelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, @marti4d is this ready for merging?

@marti4d
Copy link
Collaborator Author

marti4d commented Aug 6, 2024

@gabrielesvelto It is! And the sooner, the better, since I'm going to have to get this vendored into M-C so the C++ part of my change can use it :)

@gabrielesvelto gabrielesvelto merged commit 6f93cb2 into rust-minidump:main Aug 6, 2024
16 checks passed
@marti4d marti4d deleted the improve_auxv branch September 20, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of the auxiliary vector on Linux
3 participants