This repository has been archived by the owner on Jul 3, 2020. It is now read-only.
Fix broken build when using rust 1.37.0 support #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support debug flag on install command. Build cdylib rather than dylib.
This was referenced Sep 1, 2019
mb64
reviewed
Sep 2, 2019
|
@mb64 pushed changes. |
|
Great! LGTM – merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build using cargo-apk and rust 1.37.0 results in a binary which does not export
ANativeActivity_onCreate. Seems related to rust-lang/rust#62088.This fixes that issue and also switches to using cdylib. The cdylib switch is not necessary for the fix but it is more correct and reduces file sizes.
This also resolves #236 by supporting the debug flag in the install command and automatically builds with release. This is in line with
cargo installbehavior and it is in line with the behavior described when using--help.Should resolve #236, #235 and parts of #234.