Linearize workspace detection #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
linearize-workspace-detection
branch
from
6301ed9 to
a604f83
Compare
When `cargo` scans for a workspace it simply walks up the directories until finding the first `Cargo.toml` with a `[workspace]` declaration. All crates are detected relative to this, and no special skipping behaviour (walking further up the directories) occurs when a package was not found (was previously happening in `find_package()+member()`). Simplify the original code somewhat by making this feat more obvious, rejecting more invalid configurations.
MarijnS95
force-pushed
the
linearize-workspace-detection
branch
from
a604f83 to
da305e4
Compare
This was referenced Nov 5, 2022
Jasper-Bekkers
approved these changes
Nov 11, 2022
MarijnS95
added a commit
to MarijnS95/winit
that referenced
this pull request
Nov 23, 2022
Since rust-mobile/cargo-subcommand#23 `cargo-apk` now strictly searches for workspaces first before committing to finding the right package _within said workspace_, and bails when no package was selected since we don't support selecting (building, packaging, running) >1 target currently. Perhaps it's a bit hash to enforce this on free-form `cargo apk --` invocations, but it is what it is.
MarijnS95
added a commit
to rust-windowing/winit
that referenced
this pull request
Nov 24, 2022
* ci: Don't use `$CMD` for Android doc building Since migrating `cargo-apk` to `clap` [it is now annoying] to pass unknown arguments to an underlying `cargo` command (like `cargo doc`): fortunately generating docs doesn't need to go through `cargo apk` to set up cross-compiler/linker environment variables at all. [it is now annoying]: rust-mobile/ndk#363 * ci: Simplify * ci: Explicitly build just the `winit` package on Android Since rust-mobile/cargo-subcommand#23 `cargo-apk` now strictly searches for workspaces first before committing to finding the right package _within said workspace_, and bails when no package was selected since we don't support selecting (building, packaging, running) >1 target currently. Perhaps it's a bit hash to enforce this on free-form `cargo apk --` invocations, but it is what it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
cargoscans for a workspace it simply walks up the directories until finding the firstCargo.tomlwith a[workspace]declaration. All crates are detected relative to this, and no special skipping behaviour (walking further up the directories) occurs when a package was not found (was previously happening infind_package()+member()).Simplify the original code somewhat by making this feat more obvious, rejecting more invalid configurations.