Skip to content

Commit

Permalink
scripts: Fix off by one in makechangelog
Browse files Browse the repository at this point in the history
Use git's tformat to get a newline on the last entry, and
then we include the last commit hash in the listing too.
  • Loading branch information
bluss committed Aug 9, 2024
1 parent f563af0 commit 700b4dd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/makechangelog.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# Will produce some duplicates for PRs integrated using rebase,
# but those will not occur with current merge queue.

git log --first-parent --pretty="format:%H" "$@" | while read commit_sha
git log --first-parent --pretty="tformat:%H" "$@" | while IFS= read -r commit_sha
do
gh api "/repos/:owner/:repo/commits/${commit_sha}/pulls" \
-q ".[] | \"- \(.title) by [@\(.user.login)](\(.user.html_url)) [#\(.number)](\(.html_url))\""
Expand Down

0 comments on commit 700b4dd

Please sign in to comment.