Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for into_raw_vec_and_offset() #1432

Conversation

benliepert
Copy link
Contributor

@benliepert benliepert commented Sep 6, 2024

offset_from_alloc_to_logical_ptr() returns None, not 0 when the array is empty.

offset_from_alloc_to_logical_ptr returns None,
not 0 when the array is empty.
Copy link
Collaborator

@akern40 akern40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching this.

@akern40 akern40 merged commit 5dc62e6 into rust-ndarray:master Sep 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants