-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #110
Bump dependencies #110
Conversation
The code looks correct. I've also been playing with this locally, and we might want to tweak what However, this is breaking change, since these are public dependencies -- you're changing public trait implementations to semver-incompatible versions.
Who is "we"? Are you shipping this as an internal detail, or is it something that will be publicly visible and different than the crates.io |
oops, didn't pay enough attention when writing the text, "we" is referring to the debian rust team, the crate is used when building packages that depend on num-bigint. semver-incompatible reexports aren't much of a problem in that case. |
see also #75 |
The tests using rand/std have been moved to ci/big_rand/.
I took the liberty of rebasing this and stacking some more changes on top. The MSRV is now 1.31, and 128-bit integer support is assumed. MSRV with rand, quickcheck, and no_std are all higher, respectively 1.32, 1.34, and 1.36. We now support rand on no_std too, and I moved some of the rand and quickcheck tests to sub-crates to avoid "polluting" the main dependencies. I want to do a Rust 2018 conversion too, but I'll do that separately. Thanks! bors r+ |
Build failed |
Some 503 errors from crates.io -- let's try again. bors retry |
Build succeeded |
This bumps rand and quickcheck to the latest version. We're about to ship num-bigint with this patch applied.