Implement operators with 128bits #64
Conversation
dignifiedquire
commented
Jul 22, 2018
dignifiedquire
commented
- Depends on chore: run rustfmt on all code #63
- This is the second part to Add support for 128-bit primitives #40
|
Please rebase on the rebased+merged #63. |
dignifiedquire
force-pushed
the
u128-ops
branch
from
aadfda0 to
6ed4f0e
Compare
dignifiedquire
force-pushed
the
u128-ops
branch
from
6ed4f0e to
3593928
Compare
| if other != 0 { | ||
| if self.data.len() == 0 { | ||
| self.data.push(0); | ||
| } | ||
|
|
||
| let carry = __add2(&mut self.data, &[other]); | ||
| let carry = __add2(&mut self.data, &[other as BigDigit]); |
There was a problem hiding this comment.
Let's use From or Into here, just to future-proof that this is never lossy, e.g. &[other.into()]
(ditto for all of the similar places with a lossless cast as BigDigit.)
There was a problem hiding this comment.
I think there are a bunch of places in here already that used as instead of from/into. Should I just convert all of them, or is there any potential drawback?
There was a problem hiding this comment.
Hmm, we can leave that for future cleanup, but let's at least do that before (or during) the BigDigit upgrade.
There was a problem hiding this comment.
created a tracking issue for this: #66
| self.data.push(0); | ||
| } | ||
| __add2(&mut self.data, &[d, c, b, a]) | ||
| } else { |
There was a problem hiding this comment.
Let's debug_assert!(b > 0) here, as a self-check/documentation that smaller values were caught as u64 already.
src/biguint.rs
Outdated
| bits += big_digit::BITS; | ||
| } | ||
|
|
||
| println!("{:?} -> {}", self, ret); |
|
Thanks! bors r+ |
|
👎 Rejected by code reviews |
|
bors r+ |
Build succeeded |
62: Finish i128 support r=cuviper a=dignifiedquire Depends on #63 and #64 Implements `BigDigit = u64` ~~behind a feature flag `u64_digit`~~ for all 64-bit targets with `u128`. TODOs - [x] find a way to make the new methods that take `BigDigit`s for constructing `BigUint`s private - [x] Fix `modpow`, the last broken test. Closes #40 Co-authored-by: dignifiedquire <dignifiedquire@gmail.com> Co-authored-by: Josh Stone <cuviper@gmail.com>
