Added Pow for Big types #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR, and sorry for the late review. I think we can avoid a little overhead in
|
bors bot
added a commit
that referenced
this pull request
Aug 6, 2019
93: Optimize BigUint::modpow for even r=cuviper a=youknowone ~This work is based on #77~ ~This version only allow to take `&BigUint` as `exp` argument and doesn't manipulate `exp` not to copy the data of `exp`.~ Co-authored-by: Jeong YunWon <jeong@youknowone.org> Co-authored-by: Josh Stone <cuviper@gmail.com>
Signed-off-by: Michael Lodder <redmike7@gmail.com>
|
I rebased and implemented the simplification that I mentioned. bors r+ |
Build failed |
|
bors r+ |
Build succeeded |
ghost
pushed a commit
to tommilligan/multiplicative-persistence
that referenced
this pull request
Sep 4, 2019
21: Bump num-bigint from 0.2.2 to 0.2.3 r=tommilligan a=dependabot-preview[bot] Bumps [num-bigint](https://github.com/rust-num/num-bigint) from 0.2.2 to 0.2.3. <details> <summary>Changelog</summary> *Sourced from [num-bigint's changelog](https://github.com/rust-num/num-bigint/blob/master/RELEASES.md).* > # Release 0.2.3 (2019-09-03) > > - [`Pow` is now implemented for `BigUint` exponents][77]. > - [The optional `quickcheck` feature enables implementations of `Arbitrary`][99]. > - See the [full comparison][compare-0.2.3] for performance enhancements and more! > > [77]: [rust-num/num-bigint#77](https://github-redirect.dependabot.com/rust-num/num-bigint/pull/77) > [99]: [rust-num/num-bigint#99](https://github-redirect.dependabot.com/rust-num/num-bigint/pull/99) > [compare-0.2.3]: rust-num/num-bigint@num-bigint-0.2.2...num-bigint-0.2.3 > > **Contributors**: [@​cuviper](https://github.com/cuviper), [@​lcnr](https://github.com/lcnr), [@​maxbla](https://github.com/maxbla), [@​mikelodder7](https://github.com/mikelodder7), [@​mikong](https://github.com/mikong), > [@​TheLetterTheta](https://github.com/TheLetterTheta), [@​tspiteri](https://github.com/tspiteri), [@​XAMPPRocky](https://github.com/XAMPPRocky), [@​youknowone](https://github.com/youknowone) </details> <details> <summary>Commits</summary> - [`7417458`](rust-num/num-bigint@7417458) Merge [#108](https://github-redirect.dependabot.com/rust-num/num-bigint/issues/108) - [`e86e14b`](rust-num/num-bigint@e86e14b) Release 0.2.3 - [`f13f1e9`](rust-num/num-bigint@f13f1e9) Allow bare_trait_objects for now - [`50f6197`](rust-num/num-bigint@50f6197) Use `?` instead of deprecated `try!` - [`a473fe3`](rust-num/num-bigint@a473fe3) Merge [#107](https://github-redirect.dependabot.com/rust-num/num-bigint/issues/107) - [`9430db3`](rust-num/num-bigint@9430db3) fix(bigint): Remove unused check for BigInt lcm - [`e247980`](rust-num/num-bigint@e247980) fix(lcm): Also added fix for BigUInt - [`500d250`](rust-num/num-bigint@500d250) fix(lcm): lcm(0,0) = 0 - [`3e34876`](rust-num/num-bigint@3e34876) Merge [#99](https://github-redirect.dependabot.com/rust-num/num-bigint/issues/99) - [`edc5428`](rust-num/num-bigint@edc5428) switch quickchecks to using operations by reference - Additional commits viewable in [compare view](rust-num/num-bigint@num-bigint-0.2.2...num-bigint-0.2.3) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=num-bigint&package-manager=cargo&previous-version=0.2.2&new-version=0.2.3) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Lodder redmike7@gmail.com