Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to syn-2 #54

Merged
merged 6 commits into from
Jun 30, 2023
Merged

Update to syn-2 #54

merged 6 commits into from
Jun 30, 2023

Conversation

maurer
Copy link
Contributor

@maurer maurer commented Mar 22, 2023

Also moves a test out of doctest compilefail since syn-2 will build it correctly even without the "full" feature.

@cuviper
Copy link
Member

cuviper commented Mar 23, 2023

Do we use anything that would need "full" anymore? If not, I think we should just drop that feature. We can bump semver for the new MSRV requirement while we're at it, so a breaking feature change is ok.

cuviper
cuviper reviewed Mar 23, 2023
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@maurer
Update to syn-2
80c5e5b 
Also moves a test out of doctest compilefail since syn-2 will build it
correctly even without the "full" feature.
@maurer
Remove full-syntax feature
8436755 
The primary use-case of full-syntax (complex discriminants) is now
covered by syn even without full, so this feature is unnecessary.

Since bumping the MSRV for syn to 1.56 is a breaking change, we can drop
the full-syntax feature at the same time.
@maurer
Copy link
Contributor Author

maurer commented Mar 23, 2023

I fixed up the .unwrap() call and added an additional commit to remove the full-syntax feature. There are still some things that are not present in syn without full, but none of them seem to correspond to complex discriminants.

@glandium
Copy link

glandium commented Jun 6, 2023

@cuviper is there anything holding this up?

@cuviper
Copy link
Member

cuviper commented Jun 30, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 30, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit fce481d into rust-num:master Jun 30, 2023
3 checks passed
@cuviper
Copy link
Member

cuviper commented Jun 30, 2023

is there anything holding this up?

Lack of time and attention... but it's published now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maurer @cuviper @glandium