Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lib.rs #54

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Update lib.rs #54

merged 1 commit into from
Apr 24, 2023

Conversation

hkBst
Copy link
Contributor

@hkBst hkBst commented Mar 28, 2023

First test that qr/dm is correct, then that both methods' results are equal to the correct answer. This saves one redundant check.

small simplification
@cuviper
Copy link
Member

cuviper commented Mar 29, 2023

OK - it doesn't really matter to have redundancies in test code, but the change looks fine.

bors r+

meta: please use a more descriptive commit title in any future pull requests.

bors bot added a commit that referenced this pull request Mar 29, 2023
54: Update lib.rs r=cuviper a=hkBst

First test that qr/dm is correct, then that both methods' results are equal to the correct answer. This saves one redundant check.

Co-authored-by: Marijn Schouten <hkBst@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Mar 29, 2023

Build failed:

@cuviper
Copy link
Member

cuviper commented Mar 29, 2023

Hmm, I think the nightly compiler is misbehaving there -- I'll file an upstream bug.

@cuviper
Copy link
Member

cuviper commented Apr 24, 2023

bors retry

@bors
Copy link
Contributor

bors bot commented Apr 24, 2023

Build succeeded:

@bors bors bot merged commit 80c2b22 into rust-num:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants