Revive Float+Real in no_std thanks to libm #99

yoanlcq · 2019-02-03T12:25:21Z

Greetings,

This is a hopeful fix for #75.
Basically: Add libm as an optional dependency, and handle three possible cases depending on which features are enabled:

std and libm: std is used;
std and not libm: std is used;
libm and not std: libm and FloatCore are used.

It was briefly mentioned that libm wasn't ready yet, but this was months ago, and I believe it is better not to wait for too long.
If anything, bugs in libm should be fixed in libm; num-traits is only delegating its implementations to it; not to mention that the more libm is used, the likelier issues are to be found and hopefully fixed.

Thanks in advance!

yoanlcq · 2019-02-03T14:42:26Z

That should do; hopefully I didn't forget anything :)
EDIT: Whoops doc-tests

yoanlcq · 2019-02-03T16:07:40Z

CI fails because of overflow issues with libm. So I guess this is blocked by rust-lang/libm#4.
Apparently libm also uses some post-1.8 features which cause the 1.8 build to fail, but these look easy to fix.

src/real.rs

cuviper · 2019-02-12T23:16:52Z

Thanks for doing this - it looks great! But yes, the libm overflows are a problem...

Schultzer · 2019-05-14T17:26:57Z

Hi @yoanlcq and @cuviper a new version of libm has been released and it seams that the overflow problem with the tests in debug mode has been resolved any chance that we can move forward with this? :)

korken89 · 2019-07-23T13:56:16Z

Hi, any progress on this? cc @cuviper

142: Make libm optional r=Ogeon a=Ogeon I decided to do this to avoid having it as an unused dependency and also to hopefully be compatible with a future release of `num_traits`, where they seem to be planning the same kind of construct, judging by rust-num/num-traits#99. A transition to using `num_trait` for both cases will hopefully be seamless for the users after this. I think this also fixes #116. Co-authored-by: Erik Hedvall <erikwhedvall@gmail.com>

CryZe · 2019-09-04T07:52:37Z

I'd like to see this move forward too, as there's quite a few crates that I'd like to send PRs to for no_std support that depend on this.

yoanlcq · 2019-09-04T12:10:54Z

I think it's pretty much ready now; the only problem seems to be that libm doesn't compile on some older Rust versions supported by num-traits.

(Edit: For information, I'm not really planning to investigate these errors from libm right now).

korken89 · 2019-09-04T14:17:39Z

Awesome, thanks for doing the work!

cuviper · 2019-09-04T17:07:37Z

the only problem seems to be that libm doesn't compile on some older Rust versions supported by num-traits.

I'm OK with that -- this is new functionality for no_std users, so it's fine for this to have less compatibility. Just document that it's limited by the MSRV of the libm crate, and adjust the CI script accordingly (like i128).

yoanlcq · 2019-09-11T11:18:32Z

That should do, I hope :) Sorry for the delay.

CryZe · 2019-09-26T14:48:44Z

What's the status of this? This would unblock a lot of PRs / releases for other crates.

korken89 · 2019-09-26T15:06:06Z

It should be ready for merge, so I think we are waiting for the maintainers

Needed for some additional methods and correct overflow behavior.

cuviper · 2019-09-27T19:08:49Z

I rebased and tweaked a few things, e.g. Real doesn't need all those doc-test guards now that we're guarding the trait entirely. I think we're ready, but I'd appreciate if anyone else takes another look.

yoanlcq · 2019-09-29T18:06:20Z

The single guard in mod real is so obviously better, that I wonder why I didn't do it this way in the first place...

Anyway, I couldn't find anything "wrong" in these last changes. I would pretty confidently say "ship it"!

cuviper · 2019-09-30T16:39:01Z

The single guard in mod real is so obviously better, that I wonder why I didn't do it this way in the first place...

I think because you had the trait itself unguarded at first, only the impl depending on std/libm. So all those doctests had to be guarded whether there was any useful type available to test.

bors r+

99: Revive Float+Real in no_std thanks to libm r=cuviper a=yoanlcq Greetings, This is a hopeful fix for #75. Basically: Add `libm` as an optional dependency, and handle three possible cases depending on which features are enabled: - std and libm: std is used; - std and not libm: std is used; - libm and not std: libm and FloatCore are used. It was briefly mentioned that `libm` wasn't ready yet, but this was months ago, and I believe it is better not to wait for too long. If anything, bugs in `libm` should be fixed in `libm`; `num-traits` is only delegating its implementations to it; not to mention that the more `libm` is used, the likelier issues are to be found and hopefully fixed. Thanks in advance! Co-authored-by: Yoan Lecoq <yoanlecoq.io@gmail.com> Co-authored-by: Josh Stone <cuviper@gmail.com>

bors · 2019-09-30T16:47:16Z

Build succeeded

continuous-integration/travis-ci/push

62: Bump num-traits from 0.2.8 to 0.2.9 r=sopium a=dependabot-preview[bot] Bumps [num-traits](https://github.com/rust-num/num-traits) from 0.2.8 to 0.2.9. <details> <summary>Changelog</summary> *Sourced from [num-traits's changelog](https://github.com/rust-num/num-traits/blob/master/RELEASES.md).* > # Release 0.2.9 (2019-11-12) > > - [A new optional `libm` dependency][99] enables the `Float` and `Real` traits > in `no_std` builds. > - [The new `clamp_min` and `clamp_max`][122] limit minimum and maximum values > while preserving input `NAN`s. > - [Fixed a panic in floating point `from_str_radix` on invalid signs][126]. > - Miscellaneous documentation updates. > > **Contributors**: [@cuviper](https://github.com/cuviper), [@dingelish](https://github.com/dingelish), [@HeroicKatora](https://github.com/HeroicKatora), [@jturner314](https://github.com/jturner314), [@ocstl](https://github.com/ocstl), > [@Shnatsel](https://github.com/Shnatsel), [@termoshtt](https://github.com/termoshtt), [@waywardmonkeys](https://github.com/waywardmonkeys), [@yoanlcq](https://github.com/yoanlcq) > > [99]: [rust-num/num-traits#99](https://github-redirect.dependabot.com/rust-num/num-traits/pull/99) > [122]: [rust-num/num-traits#122](https://github-redirect.dependabot.com/rust-num/num-traits/pull/122) > [126]: [rust-num/num-traits#126](https://github-redirect.dependabot.com/rust-num/num-traits/pull/126) </details> <details> <summary>Commits</summary> - [`8eb83e2`](rust-num/num-traits@8eb83e2) Merge [#142](https://github-redirect.dependabot.com/rust-num/num-traits/issues/142) - [`b61498a`](rust-num/num-traits@b61498a) Release 0.2.9 - [`6408853`](rust-num/num-traits@6408853) Remove unused #[inline] attributes - [`4cbc27d`](rust-num/num-traits@4cbc27d) Merge [#137](https://github-redirect.dependabot.com/rust-num/num-traits/issues/137) - [`da66427`](rust-num/num-traits@da66427) Merge [#140](https://github-redirect.dependabot.com/rust-num/num-traits/issues/140) - [`da19eaf`](rust-num/num-traits@da19eaf) Compatible with cargo --remap-path-prefix - [`fdb4181`](rust-num/num-traits@fdb4181) ToPrimitive: document when `to_` methods can return `None` - [`27e3f85`](rust-num/num-traits@27e3f85) NumCast: document when `from` can return `None` - [`16cdce3`](rust-num/num-traits@16cdce3) FromPrimitive: fix some comments - [`2f0cffd`](rust-num/num-traits@2f0cffd) Merge [#99](https://github-redirect.dependabot.com/rust-num/num-traits/issues/99) - Additional commits viewable in [compare view](rust-num/num-traits@num-traits-0.2.8...num-traits-0.2.9) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)](https://dependabot.com/compatibility-score.html?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

25: Bump num-traits from 0.2.8 to 0.2.9 r=tommilligan a=dependabot-preview[bot] Bumps [num-traits](https://github.com/rust-num/num-traits) from 0.2.8 to 0.2.9. <details> <summary>Changelog</summary> *Sourced from [num-traits's changelog](https://github.com/rust-num/num-traits/blob/master/RELEASES.md).* > # Release 0.2.9 (2019-11-12) > > - [A new optional `libm` dependency][99] enables the `Float` and `Real` traits > in `no_std` builds. > - [The new `clamp_min` and `clamp_max`][122] limit minimum and maximum values > while preserving input `NAN`s. > - [Fixed a panic in floating point `from_str_radix` on invalid signs][126]. > - Miscellaneous documentation updates. > > **Contributors**: [@cuviper](https://github.com/cuviper), [@dingelish](https://github.com/dingelish), [@HeroicKatora](https://github.com/HeroicKatora), [@jturner314](https://github.com/jturner314), [@ocstl](https://github.com/ocstl), > [@Shnatsel](https://github.com/Shnatsel), [@termoshtt](https://github.com/termoshtt), [@waywardmonkeys](https://github.com/waywardmonkeys), [@yoanlcq](https://github.com/yoanlcq) > > [99]: [rust-num/num-traits#99](https://github-redirect.dependabot.com/rust-num/num-traits/pull/99) > [122]: [rust-num/num-traits#122](https://github-redirect.dependabot.com/rust-num/num-traits/pull/122) > [126]: [rust-num/num-traits#126](https://github-redirect.dependabot.com/rust-num/num-traits/pull/126) </details> <details> <summary>Commits</summary> - [`8eb83e2`](rust-num/num-traits@8eb83e2) Merge [#142](https://github-redirect.dependabot.com/rust-num/num-traits/issues/142) - [`b61498a`](rust-num/num-traits@b61498a) Release 0.2.9 - [`6408853`](rust-num/num-traits@6408853) Remove unused #[inline] attributes - [`4cbc27d`](rust-num/num-traits@4cbc27d) Merge [#137](https://github-redirect.dependabot.com/rust-num/num-traits/issues/137) - [`da66427`](rust-num/num-traits@da66427) Merge [#140](https://github-redirect.dependabot.com/rust-num/num-traits/issues/140) - [`da19eaf`](rust-num/num-traits@da19eaf) Compatible with cargo --remap-path-prefix - [`fdb4181`](rust-num/num-traits@fdb4181) ToPrimitive: document when `to_` methods can return `None` - [`27e3f85`](rust-num/num-traits@27e3f85) NumCast: document when `from` can return `None` - [`16cdce3`](rust-num/num-traits@16cdce3) FromPrimitive: fix some comments - [`2f0cffd`](rust-num/num-traits@2f0cffd) Merge [#99](https://github-redirect.dependabot.com/rust-num/num-traits/issues/99) - Additional commits viewable in [compare view](rust-num/num-traits@num-traits-0.2.8...num-traits-0.2.9) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9)](https://dependabot.com/compatibility-score.html?dependency-name=num-traits&package-manager=cargo&previous-version=0.2.8&new-version=0.2.9) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

yoanlcq mentioned this pull request Feb 3, 2019

Crate is not actually no_std yoanlcq/vek#20

Closed

cuviper reviewed Feb 12, 2019

View reviewed changes

src/real.rs Outdated Show resolved Hide resolved

cuviper mentioned this pull request Feb 26, 2019

Support MulAdd and MulAddAssign for no_std #102

Closed

cuviper added the blocked label Apr 16, 2019

korken89 mentioned this pull request Jul 23, 2019

Supporting f64 korken89/biquad-rs#1

Closed

CryZe mentioned this pull request Aug 8, 2019

Support no_std use cases by using alloc LiveSplit/livesplit-core#223

Closed

26 tasks

Ogeon mentioned this pull request Aug 11, 2019

Make libm optional Ogeon/palette#142

Merged

cuviper removed the blocked label Sep 6, 2019

jturner314 mentioned this pull request Sep 19, 2019

no_std for ndarray rust-ndarray/ndarray#708

Closed

Ogeon mentioned this pull request Sep 20, 2019

Bump palette-derive version Ogeon/palette#145

Closed

yoanlcq added 7 commits September 27, 2019 10:53

Revive Float+Real in no_std with libm

fec6c36

Make it compile on 1.8.0

b4558d1

Update README

f523f53

Impl MulAdd+MulAssign with libm fallback

4d3cb0a

libm fallback for Pow, factorize MulAdd

4234eb7

Always enable Real, feature gate Float - Real forwarding

849e2a0

Real: Run doc-tests only if Float is enabled

aaf3c26

yoanlcq and others added 12 commits September 27, 2019 10:53

Real: Ignore doc tests if Float is disabled

c28e2fe

CI: test with libm

55c5b74

Add space before triple backticks

1b28e61

Guard Real trait definition like its blanket impl for Float

4b1ea5f

Run cargo fmt --all

0547a35

CI: make the condition for testing libm the same as u128/i128

6304736

Indicate that libm feature only builds on latest Rust

2d113f5

Reference PR 99 in README

f050c60

Raise the minimum libm

27b9202

Needed for some additional methods and correct overflow behavior.

Use a single global guard in mod real

b64ee38

Don't use libm at all with std

c4256bd

Add libm to no_std CI

93328df

bors bot merged commit 93328df into rust-num:master Sep 30, 2019

malobre mentioned this pull request Oct 20, 2019

Use the libm crate for a full Float on no_std #75

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revive Float+Real in no_std thanks to libm #99

Revive Float+Real in no_std thanks to libm #99

yoanlcq commented Feb 3, 2019

yoanlcq commented Feb 3, 2019 •

edited

Loading

yoanlcq commented Feb 3, 2019 •

edited

Loading

cuviper commented Feb 12, 2019

Schultzer commented May 14, 2019

korken89 commented Jul 23, 2019

CryZe commented Sep 4, 2019

yoanlcq commented Sep 4, 2019 •

edited

Loading

korken89 commented Sep 4, 2019

cuviper commented Sep 4, 2019

yoanlcq commented Sep 11, 2019

CryZe commented Sep 26, 2019

korken89 commented Sep 26, 2019

cuviper commented Sep 27, 2019

yoanlcq commented Sep 29, 2019

cuviper commented Sep 30, 2019

bors bot commented Sep 30, 2019

Revive Float+Real in no_std thanks to libm #99

Revive Float+Real in no_std thanks to libm #99

Conversation

yoanlcq commented Feb 3, 2019

yoanlcq commented Feb 3, 2019 • edited Loading

yoanlcq commented Feb 3, 2019 • edited Loading

cuviper commented Feb 12, 2019

Schultzer commented May 14, 2019

korken89 commented Jul 23, 2019

CryZe commented Sep 4, 2019

yoanlcq commented Sep 4, 2019 • edited Loading

korken89 commented Sep 4, 2019

cuviper commented Sep 4, 2019

yoanlcq commented Sep 11, 2019

CryZe commented Sep 26, 2019

korken89 commented Sep 26, 2019

cuviper commented Sep 27, 2019

yoanlcq commented Sep 29, 2019

cuviper commented Sep 30, 2019

bors bot commented Sep 30, 2019

Build succeeded

yoanlcq commented Feb 3, 2019 •

edited

Loading

yoanlcq commented Feb 3, 2019 •

edited

Loading

yoanlcq commented Sep 4, 2019 •

edited

Loading