Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make num-macros use syn crate for compatibility with Macros 1.1 #227

Closed
hauleth opened this issue Sep 18, 2016 · 0 comments
Closed

Make num-macros use syn crate for compatibility with Macros 1.1 #227

hauleth opened this issue Sep 18, 2016 · 0 comments
Assignees
@hauleth

Comments

@hauleth
Copy link
Member

hauleth commented Sep 18, 2016

When Macros 1.1 lands in stable we would be ready to provide num-macros there also. This will mean that we need somehow parse Rust code and syntex crate is quite slow. However there is syn crate that use nom and is quite fast.
hauleth added a commit that referenced this issue Sep 18, 2016
@hauleth
Fix num-macros FromPrimitive implementation
decfedb 
Current solution follow syntax proposed in rust-lang/rfcs#1681.

Tracking issue rust-lang/rust#35900

Close #227
@hauleth hauleth mentioned this issue Sep 18, 2016
Merged
7 tasks
@hauleth hauleth self-assigned this Sep 18, 2016
hauleth added a commit that referenced this issue Sep 18, 2016
@hauleth
Fix num-macros FromPrimitive implementation
11f8289 
Current solution follow syntax proposed in rust-lang/rfcs#1681.

Tracking issue rust-lang/rust#35900

Close #227
@homu homu closed this as completed in #228 Sep 30, 2016
homu added a commit that referenced this issue Sep 30, 2016
@homu
Auto merge of #228 - rust-num:fix/num-macros, r=cuviper
019c136 
Fix `num-macros` `FromPrimitive` implementation

Current solution follow syntax proposed in rust-lang/rfcs#1681.

Tracking issue rust-lang/rust#35900

Close #227

Code broken after change:

- [ ] https://github.com/kdar/gameboy-rs
- [ ] https://github.com/lemonrock/mbedtls
- [ ] https://github.com/timorantalaiho/kelaa
- [ ] https://github.com/dylanede/cef-rs
- [ ] https://github.com/klutzy/aheui-llvm
- [ ] https://github.com/pcwalton/rust-media
- [ ] https://github.com/PistonDevelopers/hematite_server
remexre pushed a commit to remexre/num that referenced this issue Jun 1, 2017
@dtolnay
Merge pull request rust-num#227 from killercup/docs/pointer-example
4fd7a35 
Add a short example to Value::pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hauleth hauleth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hauleth