acpi: fix length of "extended_area_bytes" in RSDP search #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcerc
suggested changes
Mar 21, 2023
rsdp/src/lib.rs
Outdated
| ) | ||
| }; | ||
| let extended_area_bytes = | ||
| unsafe { slice::from_raw_parts(mapping.virtual_start().as_ptr(), mapping.mapped_length()) }; |
There was a problem hiding this comment.
This was my mistake, thank you for catching it! However, I think region_length must still be used; mapped_length returns the entire length after the start of mapping that the user mapped (which could be well over the size of the search area). Edit: If as you explained in another PR, there is no guarantee that what is returned by region_length is the same as the size passed to AcpiHandler::map_physical_region, then area.end - area.start + RSDP_V2_EXT_LENGTH should be passed to from_raw_parts instead of mapping.region_length().
There was a problem hiding this comment.
Fixed (now I understand the difference between the two lengths!)
Since the memory mapping is already including "RSDP_V2_EXT_LENGTH" bytes to allow for an ACPI 1.0 table at the end of the region, it the slice should just use the actual region length instead of going beyond it...
A0lson
force-pushed
the
rsdp_extended_area_bytes
branch
from
932c202 to
7883a67
Compare
A0lson
changed the title
rcerc
approved these changes
Apr 17, 2023
IsaacWoods
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the memory mapping is already including "RSDP_V2_EXT_LENGTH" bytes to allow for an ACPI 1.0 table at the end of the region, it seems that the slice should just use the actual mapping length instead of going beyond it...