Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building recompiles bootloader every build, resulting in extreme build times #286

Closed
BigBadE opened this issue Nov 26, 2022 · 3 comments · Fixed by #283
Closed

Building recompiles bootloader every build, resulting in extreme build times #286

BigBadE opened this issue Nov 26, 2022 · 3 comments · Fixed by #283

Comments

@BigBadE
Copy link

BigBadE commented Nov 26, 2022

Following the docs and making a simple project, a basic OS takes over 2 minutes to compile.

How to replicate:

  • Pull BigBadE/RustOS@3bb0491 (simple project, or just follow the tutorial for making one)
  • Follow setup and run cargo run once to pull dependencies
  • Build again with no changes, and compilation will take 2-4 minutes, always freezing on bootloader

Looking around Cargo issues, it looks like this issue has been reported a few times in the past (rust-lang/cargo#1162, rust-lang/cargo#1714, gimli-rs/cpp_demangle#79), but I didn't find any relevant reported issues. This build time makes running/testing extremely difficult.

@BigBadE
Copy link
Author

BigBadE commented Nov 26, 2022

Adding onto this:

  • Cloning bootloader and depending on it locally doesn't have this issue.
  • Using latest bootloader and bootloader_api.

@phil-opp
Copy link
Member

Thanks for reporting! I pushed a fix to #286, which should solve this. Could you try again with the v0.11.0-beta.4 release?

@BigBadE
Copy link
Author

BigBadE commented Nov 30, 2022

Confirmed fixed in beta.4

@BigBadE BigBadE closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants