Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bootloader v0.10 compatible with latest Rust nightlies by updating uefi-rs dependency #170

Merged
merged 6 commits into from
May 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ x86_64 = { version = "0.13.2", optional = true, default-features = false, featur
usize_conversions = { version = "0.2.0", optional = true }
bit_field = { version = "0.10.0", optional = true }
log = { version = "0.4.8", optional = true }
uefi = { version = "0.9.0", optional = true }
uefi = { version = "0.11.0", optional = true }
argh = { version = "0.1.3", optional = true }
displaydoc = { version = "0.1.7", optional = true }
conquer-once = { version = "0.2.1", optional = true, default-features = false }
Expand Down
3 changes: 3 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Unreleased

- Fix build on latest Rust nightlies by updating `uefi-rs` dependency ([#170](https://github.com/rust-osdev/bootloader/pull/170))
- Also: Fix warnings about `.intel_syntax` attribute in assembly code

# 0.10.4 – 2021-05-14

- Fix build on latest Rust nightly by updating to `uefi` v0.9.0 ([#162](https://github.com/rust-osdev/bootloader/pull/162))
Expand Down
1 change: 0 additions & 1 deletion src/asm/e820.s
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.section .boot, "awx"
.intel_syntax noprefix
.code16

# From http://wiki.osdev.org/Detecting_Memory_(x86)#Getting_an_E820_Memory_Map
Expand Down
1 change: 0 additions & 1 deletion src/asm/stage_1.s
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.section .boot-first-stage, "awx"
.global _start
.intel_syntax noprefix
.code16

# This stage initializes the stack, enables the A20 line, loads the rest of
Expand Down
1 change: 0 additions & 1 deletion src/asm/stage_2.s
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.section .boot, "awx"
.intel_syntax noprefix
.code16

# This stage sets the target operating mode, loads the kernel from disk,
Expand Down
1 change: 0 additions & 1 deletion src/asm/stage_3.s
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.section .boot, "awx"
.intel_syntax noprefix
.code32

# This stage performs some checks on the CPU (cpuid, long mode), sets up an
Expand Down
1 change: 0 additions & 1 deletion src/asm/vesa.s
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# Copyright (c) 2017 Redox OS, licensed under MIT License

.section .boot, "awx"
.intel_syntax noprefix
.code16

vesa:
Expand Down
5 changes: 4 additions & 1 deletion tests/test_kernels/higher_half/src/bin/verify_higher_half.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ fn kernel_main(_boot_info: &'static mut BootInfo) -> ! {

/// This function is called on panic.
#[panic_handler]
fn panic(_info: &PanicInfo) -> ! {
fn panic(info: &PanicInfo) -> ! {
use core::fmt::Write;

let _ = writeln!(test_kernel_higher_half::serial(), "PANIC: {}", info);
exit_qemu(QemuExitCode::Failed);
}
2 changes: 1 addition & 1 deletion tests/test_kernels/higher_half/x86_64-higher_half.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
"disable-redzone": true,
"features": "-mmx,-sse,+soft-float",
"pre-link-args": {
"ld.lld": ["--image-base", "0xFFFF800000000000"]
"ld.lld": ["--image-base", "0xFFFF800000000000", "--gc-sections"]
}
}
7 changes: 4 additions & 3 deletions x86_64-bootloader.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
"linker": "rust-lld",
"pre-link-args": {
"ld.lld": [
"--script=linker.ld"
]
"--script=linker.ld",
"--gc-sections"
]
},
"target-endian": "little",
"target-pointer-width": "64",
Expand All @@ -17,5 +18,5 @@
"disable-redzone": true,
"panic-strategy": "abort",
"executables": true,
"relocation_model": "static"
"relocation_model": "static"
}