Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified disk builder #320

Merged
merged 33 commits into from
Mar 12, 2023
Merged

Simplified disk builder #320

merged 33 commits into from
Mar 12, 2023

Commits on Mar 4, 2023

  1. Replace UefiBoot and BiosBoot with DiskImageBuilder

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    164d015 View commit details
    Browse the repository at this point in the history

  2. Update DiskImageBuilder to remove lifetime requirement by cloning, an… 

    …d convert PathBuf parameters to Path
    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    85779d3 View commit details
    Browse the repository at this point in the history

  3. Reimplement BiosBoot and UefiBoot as wrappers around DiskImageBuilder

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    5786d9b View commit details
    Browse the repository at this point in the history

  4. cargo fmt

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    131130b View commit details
    Browse the repository at this point in the history

  5. Add abi_efiapi feature

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    2a7a25c View commit details
    Browse the repository at this point in the history

  6. Fix build errors due to rebase

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    25536d2 View commit details
    Browse the repository at this point in the history

  7. Fix clippy failures

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    b472297 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary feature abi_efiapi

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    d1a2391 View commit details
    Browse the repository at this point in the history

  9. Rename image_filename to image_path

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    37c5539 View commit details
    Browse the repository at this point in the history

  10. Create enum to hold different sources of file data

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    2af185f View commit details
    Browse the repository at this point in the history

  11. Update code to use FileDataSource

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    81e9d80 View commit details
    Browse the repository at this point in the history

  12. Format code

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    c0fab37 View commit details
    Browse the repository at this point in the history

  13. Add public method to set source directly 

    This also renames the methods to add files to set_.
    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    c193f9f View commit details
    Browse the repository at this point in the history

  14. Format files after changes

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    d4e9a5f View commit details
    Browse the repository at this point in the history

  15. Refactor set methods to take destination first

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    42b5895 View commit details
    Browse the repository at this point in the history

  16. Fix warnings with

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    dd87c00 View commit details
    Browse the repository at this point in the history

  17. Add documentation comments to set_file_* methods

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    3a7fcf7 View commit details
    Browse the repository at this point in the history

  18. Add documentation comments to FileDataSource and it's public methods.

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    502967b View commit details
    Browse the repository at this point in the history

  19. Remove code comments to pass doc test.

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    ad34510 View commit details
    Browse the repository at this point in the history

  20. Final formatting pass

    @jasoncouture
    jasoncouture committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    a93ce32 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. Remove DiskImageFile in favor of a BTreeMap

    @jasoncouture
    jasoncouture committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    3ce9598 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2023

  1. Improve docs

    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    6b8d970 View commit details
    Browse the repository at this point in the history

  2. Make set_file_source private 

    We don't want to expose the `FileDataSource` enum for now.
    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    5cabc0c View commit details
    Browse the repository at this point in the history

  3. Take arguments as owned values in set_file and set_file_contents

    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    2923ad8 View commit details
    Browse the repository at this point in the history

  4. Reorder methods (public first)

    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    1a5cdf6 View commit details
    Browse the repository at this point in the history

  5. Document that only the kernel and ramdisk are loaded into memory

    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    6e9b6a3 View commit details
    Browse the repository at this point in the history

  6. Apply clippy suggestion

    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    c4714ce View commit details
    Browse the repository at this point in the history

  7. Take FileDataSource by reference in create_fat_filesystem

    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    075f22d View commit details
    Browse the repository at this point in the history

  8. Serialize boot config to Vec directly

    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    692d39f View commit details
    Browse the repository at this point in the history

  9. Take file paths by value to avoid internal cloning 

    Also: Store file paths as `Cow<'static, str>` internally to avoid cloning for const paths.
    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    bd5047c View commit details
    Browse the repository at this point in the history

  10. Follow-up fixes for by-value arguments

    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    f0328e6 View commit details
    Browse the repository at this point in the history

  11. Adjust test runner for new owned arguments

    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    ac934c4 View commit details
    Browse the repository at this point in the history

  12. Fix unused import

    @phil-opp
    phil-opp committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    e3dd6fc View commit details
    Browse the repository at this point in the history