Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on nightly 1.43.0 (05-03-2020). #25

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

Darksecond
Copy link
Contributor

The AllocRef trait has been changed slightly.
See https://doc.rust-lang.org/nightly/std/alloc/trait.AllocRef.html#tymethod.alloc.

Fix #24

@phil-opp phil-opp merged commit f63cb88 into rust-osdev:master Mar 6, 2020
@phil-opp
Copy link
Member

phil-opp commented Mar 6, 2020

Thanks a lot!

Edit: For documentation: The AllocRef change was caused by rust-lang/rust#69609.

phil-opp added a commit that referenced this pull request Mar 6, 2020
@phil-opp
Copy link
Member

phil-opp commented Mar 6, 2020

In order to avoid issues like #21, I'm going to bump the version to 0.8.0 for this. I will also make the AllocRef implementation optional behind a cargo feature to avoid future breakage for users that just need LockedHeap.

@phil-opp
Copy link
Member

phil-opp commented Mar 6, 2020

Released together with #27 as v0.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build on rust version 1.43.0-nightly
2 participants