Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EFIAPI ABI introduced in latest nightly #104

Merged
merged 2 commits into from
Nov 5, 2019

Conversation

roblabla
Copy link
Contributor

Fixes #38

Needs the very latest nightly (might not be released yet ^^).

@GabrielMajeri
Copy link
Collaborator

Thanks for the PR, I'll give it a few days to wait till the latest nightlies bring support for EFIAPI and then I'll merge it.

@GabrielMajeri
Copy link
Collaborator

Could you also update the docs to mention that people who use the entry API will need to add #![feature(abi_efiapi)] to their crate attributes for now?

@GabrielMajeri
Copy link
Collaborator

I've tested the PR on the latest nightly and the only thing missing is to also add #![feature(abi_efiapi)] to the test runner.

@roblabla
Copy link
Contributor Author

roblabla commented Nov 1, 2019

Yup, I realized that. The other problem though (unless latest nightly fixes it) is that the rustfmt packaged with the nightlies is too old to handle the EFIAPI. So CI won't pass until rustfmt is updated.

EDIT: just checked, rustfmt of nightly 2019-11-01 stil doesn't like efiapi.

@josephlr
Copy link
Contributor

josephlr commented Nov 4, 2019

I opened rust-lang/rustfmt#3903 to try to fix the rustfmt issue, but it requires updating some complex dependencies, so I think the best approach is to keep rustfmt running in the CI, but allow it to fail without failing the build.

Also, similar to r-efi/r-efi#15, this is a breaking change, so we'll need a 0.4 release for any version containing this PR.

@GabrielMajeri GabrielMajeri merged commit 6cc4182 into rust-osdev:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure ABI is correct for all targets
3 participants