Finalize memory_map module refactoring #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
memory-map
branch
7 times, most recently
from
81ff83f
to
0fe7e51
Compare
phip1611
force-pushed
the
memory-map
branch
2 times, most recently
from
b8d9455
to
2cf74f9
Compare
|
Ready for the next review-round. I incorporated your feedback into the MR. Further, I split one commit into two for better review-ability. |
phip1611
force-pushed
the
memory-map
branch
2 times, most recently
from
78b260d
to
4db0433
Compare
There is no public constructor for MemoryMapOwned, as the construction of it is quite complicated and therefore hidden behind BootServices::memory_map() respectively SystemTable::exit_boot_services. The real-world use case for the public constructors for the other types is when parsing the UEFI memory map from kernels after a bootloader, such as GRUB or Limine, passed the UEFI memory map via the corresponding boot information.
Simplify MemoryMapOwned::from_initialized_mem to simplify and streamline the construction in unit tests.
Add a test that imitates how a public API user would utilize our abstractions to parse a chunk of memory as UEFI memory map.
nicholasbishop
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is (hopefully) the final step of our recent refactorings for the new
memory_mapmodule and all its traits and implementations. I think we are now in good shape to cover a variety of use-cases. Code inconsistencies are resolved, code structure has improved, documentation is comprehensive. Anything missing? Any comments?This closes #1247.
Checklist