replace software_interrupt! macro with generic function #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if this function has to be |
josephlr
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
I like this change (I was about to propose something similar). Can you open this pull request against the next branch rather than the master branch? I think having all the breaking changes in a dev branch will help us determine when we next want to cut a breaking release of this crate.
EDIT: I just realized I can do this myself.
As we're merging against the next branch, no need to update Changelog.md right now, that can wait until we merge next into master.
phil-opp
approved these changes
Jun 4, 2021
josephlr
added a commit
that referenced
this pull request
Jun 4, 2021
josephlr
pushed a commit
to josephlr/x86_64
that referenced
this pull request
Jul 18, 2021
This is a *breaking change*, also add note about safety.
josephlr
added a commit
to josephlr/x86_64
that referenced
this pull request
Jul 18, 2021
Followup to rust-osdev#259. Code previously merged as part of rust-osdev#227. Signed-off-by: Joe Richey <joerichey@google.com>
Freax13
pushed a commit
to Freax13/x86_64
that referenced
this pull request
Oct 17, 2021
Followup to rust-osdev#259. Code previously merged as part of rust-osdev#227. Signed-off-by: Joe Richey <joerichey@google.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr replaces the
software_interrupt!macro with a generic function.This is a breaking change.