Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove const_assert! in favor of std's assert! #326

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Dec 2, 2021

Rust 1.57 was just released and "panic! in const contexts" has finally been stabilized 🎉. This pr removes the hacky const_assert! macro that we previously used to conditionally abort the compilation in const contexts.

@Freax13 Freax13 requested a review from josephlr December 2, 2021 20:59
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for remembering this!

@Freax13 Freax13 merged commit 55d5fad into rust-osdev:master Dec 5, 2021
@Freax13 Freax13 deleted the const-panic branch December 5, 2021 15:27
@phil-opp phil-opp mentioned this pull request Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants