Update Docs and CI to note MSRV #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlr
force-pushed
the
stable
branch
6 times, most recently
from
61316a8 to
072de2e
Compare
Freax13
approved these changes
Mar 26, 2022
| @@ -1336,6 +1336,7 @@ macro_rules! set_general_handler_entry { | |||
| mod test { | |||
| use super::*; | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Suggested change
| #[allow(dead_code)] | |
| #[cfg(not(windows))] |
There was a problem hiding this comment.
It seems like the downside here is that this change causes cargo test to emit warning on some of our runs, see https://github.com/rust-osdev/x86_64/runs/5705768152
I think it's easier to just have #[allow(dead_code)] then trying to keep the helper method's cfgs in sync with the test below.
Signed-off-by: Joe Richey <joerichey@google.com>
This uses the `rust-version` feature added in Rust 1.56 Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
josephlr
force-pushed
the
stable
branch
2 times, most recently
from
27e726d to
43965df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates our
READMEto note what our Minimum Supported Rust Version (MSRV) is for each feature configuration. It also uses therust-versioncargo feature to make this information consumable by cargo.Our MSRVs are:
not(instructions)andnot(nightly)- Rust 1.57instructionsandnot(nightly)- Rust 1.59nightly- Rust Nightly (sufficiently recent)I also updated some of our tests so that things would build/test on stable without errors or warnings. Finally, I updated the CI to actually test our MSRV (by moving some of our tests to a different "stable" job).
Signed-off-by: Joe Richey joerichey@google.com