tss: Initialize iopb to be empty instead of zero #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Richey <joerichey@google.com>
Freax13
approved these changes
Mar 26, 2022
There was a problem hiding this comment.
Looks good to me, thanks!
To make the IOPB invalid we set it to
1more than the TSS segment limit. This is what linux does.
To quote the Intel SDM:
If the I/O bit map base address is greater than or equal to the TSS segment limit, there is no I/O permission map, [...] (Volume 1, 19.5.2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #195.
To make the IOPB invalid we set it to
1more than the TSS segment limit. This is what linux does.Signed-off-by: Joe Richey joerichey@google.com