gdt: Improve panic message when SystemSegment is pushed #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
|
Build failure is unrelated, see rust-osdev/uart_16550#22 |
I just released a new |
Signed-off-by: Joe Richey <joerichey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor, non-breaking change.
When pushing a
SystemSegmentthe GDT has to have two entries free. Rather than pushing part of theSystemSegmentand then panicking, we can panic before we even modify the GDT, and give a better error message. This new behavior also seems less surprising, as normally if a mutation operation panics, the structure isn't modified.I also renamed the
next_freeprivate member tolen(with these changes it makes the code more readable). I also added some tests to make sure we are correctly handling theadd_entrycommand.Signed-off-by: Joe Richey joerichey@google.com