gdt: Check that MAX is in range #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GDT can have a maxium length of 2^16 bytes, and must contain at least one null descriptor. As `MAX` counts the number of `u64` entries, we must have `0 < MAX <= 2^13`. Unfortunely, we cannot do this check with a `where` clause, as `feature(generic_const_expers)` is not yet stable. However, we can do this check with an `assert!` in `GlobalDescriptorTable::empty()`, which is a `const fn`. Pointed out by @Freax13 in #360 (comment) Signed-off-by: Joe Richey <joerichey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GDT can have a maxium length of 2^16 bytes, and must contain at
least one null descriptor. As
MAXcounts the number ofu64entries,we must have
0 < MAX <= 2^13.Unfortunely, we cannot do this check with a
whereclause, asfeature(generic_const_expers)is not yet stable. However, we can dothis check with an
assert!inGlobalDescriptorTable::empty(), whichis a
const fn.Pointed out by @Freax13 in
#360 (comment)
Signed-off-by: Joe Richey joerichey@google.com