Conditionally disable file fallback for Android and Linux #396
Conversation
newpavlov
changed the title
target_arches
newpavlov
force-pushed
the
whitelist_fallback
branch
from
e1ffdf6
to
2cc9413
Compare
newpavlov
changed the title
| // getrandom(2) was introduced in Linux 3.17 | ||
| static HAS_GETRANDOM: LazyBool = LazyBool::new(); | ||
| if HAS_GETRANDOM.unsync_init(is_getrandom_available) { | ||
| sys_fill_exact(dest, getrandom_syscall) |
There was a problem hiding this comment.
Sorry to contradict my earlier suggestion, but I think I have a better one: Let's change this line to linux_android::getrandom_inner(dest). This way, it will crystal clear that the logic is EXACTLY the same as the no-fallback case. This would also allow you to keep getrandom_syscall in linux_android, which I think would be better than putting it in libc_util.
There was a problem hiding this comment.
We need getrandom_syscall for checking getrandom availability, so I think the current solution is fine.
newpavlov
force-pushed
the
whitelist_fallback
branch
from
9c60413
to
7a4ed41
Compare
|
@josephlr WDYT? |
I think we can discuss it here. It looks like the Nightly is broken on some targets which causes breakage of some CI jobs, so I do not plan to merge it right away. |
|
The CI failures are caused by Nightly issues and not relevant to this PR, so we can merge it. |
The file fallback is left enabled for Android targets and for Linux targets which support pre-3.17 kernels.
This PR also adds
linux_disable_fallbackcrate feature and removes catching ofEPERMduringgetrandomavailability check on Android targets.Closes #376
Closes #229
cc @briansmith