Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc links #1078

Merged
merged 3 commits into from
Dec 15, 2020
Merged

Fix doc links #1078

merged 3 commits into from
Dec 15, 2020

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Dec 15, 2020

Closes #1077:

  • add a redirect at https://rust-random.github.io/rand/ (have to test this live)
  • use docs.rs for documentation links, since people usually want doc corresponding to the published version not the master branch
  • use the book as the "homepage" since linking back to the crate pages is not useful and we already have a repo link

@dhardy dhardy requested a review from vks December 15, 2020 10:15
@dhardy
Copy link
Member Author

dhardy commented Dec 15, 2020

PS once approved, I'll push equivalent changes into the rngs repo.

Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dhardy dhardy merged commit d4b180d into master Dec 15, 2020
@dhardy
Copy link
Member Author

dhardy commented Dec 15, 2020

The redirect doesn't work: URL is still 404. Did I get the path wrong?

@newpavlov
Copy link
Member

It redirects me without problem. Likely it got updated a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation link on crates.io doesn't work
2 participants