Replace SeedableRng impl for SmallRng with inherent fns #1368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1285 by:
SeedableRng
impl forSmallRng
. Use inherent fns instead.Seed
type forStdRng
(the only practical effect is to make a possible future breaking change to the API more obvious).Loss of functionality:
SmallRng
can no longer be used in generics requiring aSeedableRng
bound. As such, it can also no longer be reseeded from generic code. Is this an issue?SmallRng::from_seed
function. This is deliberate since most useful uses require a portable RNG.