Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 0.4.1 #211

Closed
wants to merge 1 commit into from
Closed

Release: 0.4.1 #211

wants to merge 1 commit into from

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Dec 17, 2017

No description provided.

## [0.4.1] - 2017-12-17
### Added
- `no_std` support

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few other changes:

  • Added HC-128 RNG. Maybe with the description that it is similar to ISAAC, but proven to be cryptographically secure and often faster.
  • Technically Isaac64Rng::next_u32 is a breaking change, because it no longer throws away half the results.
  • {IsaacRng, Isaac64Rng}::new_unseeded is no longer available. Use {IsaacRng, Isaac64Rng}::new_from_u64(0) as replacement.
  • RNG's no longer implement Copy.
  • RNG's have a custom Debug implementation that does not expose the internal state.

Does it make sense to say something about impls? Or not advertise it too widely, because it may move to rand_core?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any of that's merged yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was your goal to include them in this release after #205 (comment). Because they contain (small) breaking changes, they can't be part of 0.4.* if we follow semver.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments. Didn't think about lack of Copy being a breaking change, but you're right, it is (maybe we should add a deprecated impl?). new_unseeded we can potentially add back as a deprecated wrapper fn. So perhaps those changes can't land in 0.4 after all, or at least not all of them :/

BTW it should have been clear from this PR what was/wasn't in the release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I finally get the scheme you have in mind 😄

@pitdicker
Copy link
Contributor

pitdicker commented Dec 17, 2017

Two small PR's that may be worth including before a release: #187 and #179

@pitdicker pitdicker mentioned this pull request Dec 18, 2017
@dhardy
Copy link
Member Author

dhardy commented Dec 18, 2017

Merged (via rebase). Probably 0.4.2 won't be too far away so won't feature creep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants