Make Fill_via_u*_chunks not modify src
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
reviewed
Jan 21, 2018
src/impls.rs
Outdated
| unsafe { | ||
| // N.B. https://github.com/rust-lang/rust/issues/22776 | ||
| let bytes = transmute::<_, [u8; $size]>(n.to_le()); | ||
| copy_nonoverlapping((&bytes).as_ptr(), |
There was a problem hiding this comment.
bytes is an array, so bytes.as_ptr() should be the same? I'd prefer the following, though unfortunately it means passing another parameter (or get size from size_of):
let tmp = n.to_le();
let src_ptr = &tmp as *const $ty as *const [u8; $size]; // inline this is you like
I don't think you need to reference that bug; I think Rust's lifetime analysis is good enough now to prevent it.
|
Thank you, your alternative looks better 😄. |
|
Glad it worked out. Now we have 4 PRs ready except for CI; hmm... |
|
Yes... All these changes are platform-independent. If the CI passes on Linux, would it be ok to merge? |
|
It's big-endian tests that are really missed. Maybe we do need to port your Travis tweaks to this branch. |
|
I also missed them for the ChaCha PR... Maybe it is best to use just one big-endian platform from it. |
pitdicker
pushed a commit
that referenced
this pull request
Apr 4, 2018
Make `Fill_via_u*_chunks` not modify `src`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I now have 4 branches with
BlockRngCoretrait experiments, but it is hard to get them in a reviewable state. It is mostly the addition of aBlockRngwrapper and just a lot of code moving around.One functional change is the one in this PR. Because it touches somewhat difficult code using unsafe it seemed best to split it out.
Another thing I can split out are changes to the documentation of ChaCha.