Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port reseeding #252

Merged
merged 5 commits into from
Feb 18, 2018
Merged

Port reseeding #252

merged 5 commits into from
Feb 18, 2018

Conversation

pitdicker
Copy link
Contributor

This is based on top of #235, and most of the code changes come from dhardy#76. I have added logging, and attempted to improve the documentation a bit for #230 (I also changed the documentation for thread_rng, but will make that part of a separate PR).

src/reseeding.rs Outdated
/// good CSPRNG). Previous implementations of `thread_rng` for example used
/// `ReseedingRng` with the ISAAC RNG. That algorithm, although seemingly
/// strong, does not come with a security proof and does not meet the current
/// standards for a cryptographically secure PRNG. By reseeding it very
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by 'does not meet the current standards for a cryptographically secure PRNG'? Is there something specific? If not, I'd rather not say this, because it sounds like there's a known defect in ISAAC, where as far as I know there's not (other than the already mentioned lack of proof of security).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the impression I got from reading a bunch op papers, I remember one paper putting it in a table with 'previous generation' compared to 'suited for current use'. (Those where not the exact names, because I really don't know which paper it was). But you are right, no reason to talk bad here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I'll leave the choice of words here up to you. I just don't like what should be science being reduced to hear-say, although I get that evidence can be hard to find.

@dhardy
Copy link
Member

dhardy commented Feb 5, 2018

I like this but had to correct your English a few times ;-).

Please:

git fetch --all
git cherry-pick ff1bd8be9b9
git rebase master

@pitdicker
Copy link
Contributor Author

Thanks for your corrections!

Sorry for the slow replies, I hope to do better next week.

@dhardy
Copy link
Member

dhardy commented Feb 17, 2018

May want some tweaks in line with #249

@pitdicker
Copy link
Contributor Author

pitdicker commented Feb 17, 2018

Rebased.

Edit: just now saw your comment above.

@dhardy dhardy merged commit d3fee23 into rust-random:master Feb 18, 2018
@pitdicker pitdicker mentioned this pull request Feb 24, 2018
33 tasks
@pitdicker pitdicker deleted the port_reseeding branch March 1, 2018 19:36
pitdicker pushed a commit that referenced this pull request Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants