-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port reseeding #252
Port reseeding #252
Conversation
49637d9
to
5ef4f6f
Compare
src/reseeding.rs
Outdated
/// good CSPRNG). Previous implementations of `thread_rng` for example used | ||
/// `ReseedingRng` with the ISAAC RNG. That algorithm, although seemingly | ||
/// strong, does not come with a security proof and does not meet the current | ||
/// standards for a cryptographically secure PRNG. By reseeding it very |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by 'does not meet the current standards for a cryptographically secure PRNG'? Is there something specific? If not, I'd rather not say this, because it sounds like there's a known defect in ISAAC, where as far as I know there's not (other than the already mentioned lack of proof of security).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the impression I got from reading a bunch op papers, I remember one paper putting it in a table with 'previous generation' compared to 'suited for current use'. (Those where not the exact names, because I really don't know which paper it was). But you are right, no reason to talk bad here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'll leave the choice of words here up to you. I just don't like what should be science being reduced to hear-say, although I get that evidence can be hard to find.
I like this but had to correct your English a few times ;-). Please:
|
5ef4f6f
to
c503099
Compare
Thanks for your corrections! Sorry for the slow replies, I hope to do better next week. |
May want some tweaks in line with #249 |
c503099
to
7092b83
Compare
Rebased. Edit: just now saw your comment above. |
7092b83
to
46ad0fc
Compare
This is based on top of #235, and most of the code changes come from dhardy#76. I have added logging, and attempted to improve the documentation a bit for #230 (I also changed the documentation for
thread_rng
, but will make that part of a separate PR).