Make libc dependency optional #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jan 8, 2020
| @@ -279,11 +279,10 @@ where | |||
| } | |||
|
|
|||
|
|
|||
| #[cfg(all(unix, not(target_os = "emscripten")))] | |||
| #[cfg(all(unix, feature = "std", not(target_os = "emscripten")))] | |||
| mod fork { | |||
There was a problem hiding this comment.
This requires libc and not std, right?
Edit: missed that you switched to Once.
There was a problem hiding this comment.
Once requires std. std implies libc in the Cargo.toml
There was a problem hiding this comment.
Yes, it was a separate commit, so may be confusing.
Because you commented on #927 and it's sometimes difficult getting reviews done around here. |
|
LGTM |
|
Can you publish a new release with this change? |
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #911 and #927.
(Although the plan is still to restrict
ReseedingRngtostdfor 0.8.)Review please @Amanieu / @BurtonQin / @bjorn3 (and apologies for the delay).