-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): fix unchecked lock and update deps #107
Conversation
j-mendez
commented
Feb 25, 2023
- build(deps): update cssparser@0.29.6 and selector@0.24.0 (mem reduction, perf increase, and css3 syntax fixes )
- fix missing Cargo.lock file
- add lazy evaluation classes
@cfvescovo @cfvescovo We can use or for this block in the fn is_root(&self) -> bool {
self.parent()
.map_or_else(|| false, |parent| parent.value().is_document())
} |
I know but Rust's collections generally don't allocate on initialisation, so an eager String::new() or HashMap::new() doesn't really matter |
However I see your point so I removed my comment |
We want to leave the stack alone for this and should be fine to move it lazy. I can revert the change to keep it just with the build deps. |
I was referencing this: https://stackoverflow.com/a/73785382 |
Keep your changes, I see your point. It won't make much of a difference but ok. |
@cfvescovo thank you for the fast replies - fixing the format issues now. |
Cargo fmt is complaining, rerun the formatter |
@j-mendez thank you! |