Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put collecting parser errors behind a default feature. #118

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Put collecting parser errors behind a default feature. #118

merged 1 commit into from
Mar 3, 2023

Conversation

adamreichold
Copy link
Member

To be honest, I just noticed that the errors field actually exists and in my scraper code never looked at it so far. I am just extracting what I can. So it seems preferable to investing any (computational) effort into collecting them, at least if they are not desired.

@cfvescovo
Copy link
Member

LGTM

@j-mendez
Copy link
Member

j-mendez commented Mar 2, 2023

Nice changes!!

@cfvescovo cfvescovo merged commit f06bd0b into rust-scraper:master Mar 3, 2023
@adamreichold adamreichold deleted the optional-errors branch March 3, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants