fix: have benchmark test clean working directory #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before checking out different commits, clean the working directory to avoid checkout failures to to temporary files created during benchmark execution (as is done by linux-loader) Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
requested review from
andreeaflorescu,
lauralt,
sameo and
ShadowCurse
as code owners
|
I've tested this locally using linux-loader. With this commit, the benchmarks on rust-vmm/linux-loader#198 pass |
rbradford
approved these changes
Oct 17, 2024
ShadowCurse
approved these changes
Oct 17, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before checking out different commits, clean the working directory to avoid checkout failures to to temporary files created during benchmark execution (as is done by linux-loader)
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.