Remove code duplication in tests #140
Conversation
DeliaPavel
requested review from
alexandruag,
jiangliu and
slp
as code owners
Create function test_state in state.rs that holds the duplicated code from function test_invalid_avail_idx from queue.rs and function test_queue_guard_object from queue_guard.rs Fixes #122 Signed-off-by: Delia-Maria PAVEL (101431) <delia_maria.pavel@stud.acs.upb.ro>
| // No descriptor chains are consumed at this point. | ||
| assert_eq!(q.next_avail(), 0); | ||
| assert_eq!(q.next_used(), 0); | ||
| assert_eq!(state.next_avail(), 0); |
There was a problem hiding this comment.
The problem with this refactoring is that you are no longer calling these methods from the Queue/QueueGuard implementation, but always from the QueueState one. Because of this, having two separate tests doesn't actually make much sense anymore. I'll think about what we can do regarding this.
There was a problem hiding this comment.
I didn't find any solution to this without some serious refactoring. One way of achieving this is to implement the same trait on both QueueGuard and Queue, and the test case receive as a parameter a parametrized Q where Q implements the common trait. This is extending far beyond the scope of the opened issue. The code in Queue and QueueGuard is duplicated as well, but I think that needs to be handled as a separate issue
There was a problem hiding this comment.
I didn't find any solution to this without some serious refactoring. One way of achieving this is to implement the same trait on both QueueGuard and Queue, and the test case receive as a parameter a parametrized Q where Q implements the common trait. This is extending far beyond the scope of the opened issue. The code in Queue and QueueGuard is duplicated as well, but I think that needs to be handled as a separate issue
I agree, so should we drop this patch for now?
Create function test_state in state.rs that holds the duplicated code
from function test_invalid_avail_idx from queue.rs and function
test_queue_guard_object from queue_guard.rs
Fixes #122
Signed-off-by: Delia-Maria PAVEL (101431) delia_maria.pavel@stud.acs.upb.ro
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
unsafecode is properly documented.