Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative names for cursor icons #11

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

Friz64
Copy link
Contributor

@Friz64 Friz64 commented Oct 30, 2023

Many cursor themes in the wild don't adhere to the w3c standard, and only use legacy names.

The list in this PR is from a list in an older version of winit, keeping only the names that don't match the standard.

Also see: Smithay/client-toolkit#425

cc @kchibisov

@kchibisov
Copy link
Member

Could you check what Qt and GTK are using as well?

@Friz64
Copy link
Contributor Author

Friz64 commented Oct 30, 2023

Could you check what Qt and GTK are using as well?

Good call. Qt especially had a lot of alternatives.

How close should we stay to the original cursor? Let's for example look at CursorIcon::Copy, which is described as "Indicates something is to be copied. Often rendered as an arrow with a small plus sign next to it.". My cursor theme does not have that exact icon, but it does have a drag&drop variant of it (referred to as dnd-copy) where instead of the arrow, there is a dragging hand. Should this be listed or should we stay as close to the original as possible? My current version opts to not list it.

src/lib.rs Outdated Show resolved Hide resolved
@kchibisov
Copy link
Member

How close should we stay to the original cursor? Let's for example look at CursorIcon::Copy, which is described as "Indicates something is to be copied. Often rendered as an arrow with a small plus sign next to it.". My cursor theme does not have that exact icon, but it does have a drag&drop variant of it (referred to as dnd-copy) where instead of the arrow, there is a dragging hand. Should this be listed or should we stay as close to the original as possible? My current version opts to not list it.

No, if it doesn't have it then it doesn't have it.

From Qt, previously overlooked
@kchibisov kchibisov merged commit 9d77551 into rust-windowing:main Nov 2, 2023
4 checks passed
@kchibisov
Copy link
Member

Thanks.

@Friz64 Friz64 deleted the alt-cursor-names branch November 2, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants