Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cursor-icon version 1.0.0 #2

Merged
merged 1 commit into from
May 9, 2023

Conversation

kchibisov
Copy link
Member

@madsmtm
Copy link
Member

madsmtm commented May 8, 2023

Let's add a no-op alloc feature first, something like:

[features]
default = ["std"]
std = ["alloc"]
alloc = []
// For forwards compatibility
#[cfg(feature = "alloc")]
extern crate alloc as _;

Details.

@kchibisov
Copy link
Member Author

kchibisov commented May 8, 2023

But adding a feature is not a breaking change?

Haven't noticed your link.

@kchibisov
Copy link
Member Author

@madsmtm done in b384d99

@kchibisov
Copy link
Member Author

kchibisov commented May 8, 2023

Adding aliases is not justified, see https://www.freedesktop.org/wiki/Specifications/cursor-spec/ . There's a movement to use standard icon names, so we can keep everything the way it is. And most cursor themes have all the variants listed in that spec already.

Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the API Guidelines Checklist and made PRs for the things I found missing. Aside from that, looks good to me!

Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@i509VCB
Copy link

i509VCB commented May 8, 2023

I'll mention this from matrix given that went into legal off topic:

Should we include documentation for CursorIcon::from_str to specify what string values are expected. I'd guess it's the CSS values from quickly searching?

@kchibisov
Copy link
Member Author

Should we include documentation for CursorIcon::from_str to specify what string values are expected. I'd guess it's the CSS values from quickly searching?

Done in 92dd3e6

@kchibisov kchibisov merged commit 108c2a1 into rust-windowing:main May 9, 2023
@kchibisov kchibisov deleted the release-1.0.0 branch May 9, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants