Add WinRT CoreWindow handle #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Lokathor
approved these changes
Feb 24, 2021
Friz64
pushed a commit
to Friz64/raw-window-handle
that referenced
this pull request
Jun 2, 2021
* Add WinRT core window handle * cargo fmt
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this crate lacks an entry for Windows WinRT, which uses CoreWindow instead of HWND and other Win32 stuff for handling the windowing.
This pull request implements the
WinRTvariant onRawWindowHandle, holdingWinRTHandlestruct. TheWinRTHandlestruct currently has a single member,core_window, which is intended to contain a pointer to aCoreWindowinstance. This implementation is chosen to match SDL2 which also exposes only theCoreWindow, and because it is the minimum currently needed for creating a swapchain on DX12 under WinRT see here.I just copy pasted the existing
Windowsvariant, renamed it and replaced the struct members.