Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use objc2 and its framework crates #15

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented May 1, 2024

objc2 is a replacement for objc/objc_id that contains a bunch of safety improvements, including automatically generated type-safe APIs objc2-foundation/objc2-app-kit/objc2-quartz-core/objc2-ui-kit and Id which makes memory management very clear.

This is currently a draft, as it uses yet-unreleased parts of objc2-quartz-core, as well as the unreleased objc2-ui-kit crate.

Fixes #13.

src/appkit.rs Outdated Show resolved Hide resolved
@madsmtm madsmtm marked this pull request as ready for review June 1, 2024 16:00
@madsmtm madsmtm requested a review from MarijnS95 June 25, 2024 20:03
@madsmtm madsmtm force-pushed the objc2 branch 2 times, most recently from 17c9872 to 4a3978b Compare June 28, 2024 17:57
This makes the memory management very clear, and uses a type-safe API to
access everything.
src/appkit.rs Show resolved Hide resolved
src/appkit.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/appkit.rs Outdated Show resolved Hide resolved
src/uikit.rs Outdated Show resolved Hide resolved
src/uikit.rs Outdated Show resolved Hide resolved
src/appkit.rs Outdated Show resolved Hide resolved
src/uikit.rs Outdated Show resolved Hide resolved
src/uikit.rs Outdated Show resolved Hide resolved
@madsmtm madsmtm requested a review from MarijnS95 June 28, 2024 21:35
@madsmtm madsmtm merged commit d3f10bd into rust-windowing:master Sep 4, 2024
2 checks passed
@madsmtm madsmtm deleted the objc2 branch September 4, 2024 06:16
@madsmtm
Copy link
Member Author

madsmtm commented Sep 4, 2024

Went ahead and merged this now, but thanks for the review!

@MarijnS95
Copy link
Member

Went ahead and merged this now

Apologies, I never got around to read through the MacOS documentation to catch back up with anything I didn't understand! Completed the review now!

src/lib.rs Show resolved Hide resolved
src/appkit.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/appkit.rs Show resolved Hide resolved
src/uikit.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Release of allocated metal layers
2 participants