-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for Windows under GNU are experiencing a linker failure #142
Comments
I'm guessing this is an issue with how the build environment is set up on CI and not really a Softbuffer issue... still haven't booted into Windows and tried to reproduce it though. I previously had weird compile issues in a project with the Windows gnu toolchain running under msys2 with a Rust install from outside msys2; which was fixed by just using msys2's version of Rust. Some weird compile error started happening that hadn't before, but I don't remember if it was like this one: pop-os/keyboard-configurator@0b5827a. |
Looking up the error, it looks like these warnings would happen if the libraries were built with msvc, but linked with gnu ld, which doesn't use that directive? Not sure why that would be happening. |
Ah: rust-lang/rust#112368. Looks like the warnings appear starting in Rust 1.70, which updates LLVM to have llvm/llvm-project@c5b3de6. The directive would be supported with a sufficiently new version of ld or lld. But it should just be a warning and work anyway? It's not obvious to my looking at the logs why this is causing a compile failure. All the messages the linker is printing are warnings. Anyway, it doesn't seem to be a Softbuffer issue, and would occur with any Rust code built in the same environment. I guess... (Edit: Or well, unless the actual error is something else.) |
microsoft/windows-rs#2614 (comment) I guess the problem is that ld is crashing, not erroring, with nothing useful logged? But it shouldn't be an issue with newer versions of ld. In any case, not really softbuffer related. |
They are currently failing due to what we believe is a bug in the Windows bindings for Rust. For now, disable these until this bug is resolved. Closes #142 Signed-off-by: John Nunley <dev@notgull.net>
They are currently failing due to what we believe is a bug in the Windows bindings for Rust. For now, disable these until this bug is resolved. Closes #142 Signed-off-by: John Nunley <dev@notgull.net>
Taken from the latest CI logs:
This failure only occurs for
*-pc-windows-gnu
, not*-pc-windows-msvc
. Also it apparently only happens under Windows, as I can build it forx86_64-pc-windows-gnu
just fine on my Linux laptop.I need to go to bed now, but I'll investigate this on my Windows VM this week.
The text was updated successfully, but these errors were encountered: