Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic upon closing the app on iOS #1168

Merged
merged 2 commits into from Oct 16, 2019
Merged

Fix panic upon closing the app on iOS #1168

merged 2 commits into from Oct 16, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 16, 2019

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@ghost
Copy link
Author

ghost commented Sep 16, 2019

r? @mtak-
I'm not sure if this should be waiting for both ProcessingEvents and ProcessingRedraws. For me this was only ever called with ProcessingEvents, but I'm not using a directly Metal-backed view (instead it's a sublayer), so perhaps I'm triggering a different code path than your application.

@Osspial Osspial mentioned this pull request Sep 26, 2019
7 tasks
@Osspial
Copy link
Contributor

Osspial commented Oct 5, 2019

Is this good to merge? cc @mtak- again

@Osspial
Copy link
Contributor

Osspial commented Oct 9, 2019

Are there any example Winit Metal applications this could be tested with?

@ghost
Copy link
Author

ghost commented Oct 12, 2019

It looks like glutin is creating a directly GL-backed view for the window, so this can be tested with the glutin examples. The changes here look correct. The panic can be reproduced with these examples, and the issue is fixed after applying the changes in this pull request.

@Osspial Osspial merged commit de33a92 into rust-windowing:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants