Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interaction between fullscreen windows and monitor-switching keyboard shortcuts #1171

Merged

Conversation

Osspial
Copy link
Contributor

@Osspial Osspial commented Sep 17, 2019

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

For background: on multi-monitor Windows systems, you can press WIN+Shift+<arrow key> to switch the active window to a new monitor. If the window is maximized, Windows will automatically adjust the window's size so it's maximized on the new monitor; however, if the window is in borderless fullscreen mode, Windows will not adjust the window size and it will retain the size of the monitor the window was switched from. This PR updates the behavior to properly change the window size to reflect the new monitor. It also disables monitor-switching window moves when the window is in exclusive fullscreen mode, since exclusive fullscreened windows should logically be locked to the monitor where they have exclusive access.

@Osspial Osspial mentioned this pull request Sep 26, 2019
7 tasks
@Osspial Osspial force-pushed the improved-fullscreen-monitor-switching branch from 7914b89 to 6bae6b3 Compare October 5, 2019 19:14
@Osspial Osspial force-pushed the improved-fullscreen-monitor-switching branch from 6bae6b3 to 285f838 Compare October 5, 2019 19:15
@Osspial Osspial merged commit df7571b into rust-windowing:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant