Wayland support for set_cursor_grab and set_cursor_visible #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_manager_v1" callback comes after the "wl_seat" callback
… the cursor enters the surface. Making the cursor visible again still only happens once the cursor re-enters the surface
elinorbgr
reviewed
Sep 22, 2019
…s to the relative_pointer_manager_proxy will happen on the same thread.
|
In light of the comment about Arc Mutex vs Rc RefCell in #1179 I switched to using Rc and RefCell most places |
…sor back to visible on wayland.
elinorbgr
reviewed
Sep 22, 2019
|
fwiw I can confirm that this PR works fine in alacritty. Ideally we should set to a previous cursor instead of |
|
Any updates on this? What remains to do in order to get this reviewed and merged in? |
elinorbgr
approved these changes
Sep 30, 2019
kchibisov
reviewed
Oct 1, 2019
Co-Authored-By: Kirill Chibisov <wchibisovkirill@gmail.com>
|
Thanks! Merging! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for set_cursor_grab and set_cursor_visible. There is currently a know limitation that if when making the cursor visible it does not take effect until the cursor re-enters the window surface.