Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement requestAnimationFrame for web #1519

Merged
merged 4 commits into from
Apr 11, 2020
Merged

Implement requestAnimationFrame for web #1519

merged 4 commits into from
Apr 11, 2020

Conversation

chemicstry
Copy link
Contributor

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

Implementation based on discussion in #1493. I did not implement requestPostAnimationFrame because it's not documented properly yet and does not exist in stdweb or web_sys either.

@chemicstry
Copy link
Contributor Author

Not sure why windows CI failed (can someone rerun?), but otherwise this is ready for review

@azriel91 azriel91 mentioned this pull request Apr 5, 2020
Closed
ryanisaacg
ryanisaacg approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@ryanisaacg ryanisaacg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I had the same (presumably spurious) Windows CI failure in #1512. This has re-ignited me to try to get it fixed, so we can land both of these changes.

@ryanisaacg ryanisaacg added DS - web P - high Vital to have S - enhancement Wouldn't this be the coolest? labels Apr 6, 2020
@ryanisaacg
Copy link
Contributor

Ok, got CI to pass. Thanks again!

@ryanisaacg ryanisaacg merged commit 1f24a09 into rust-windowing:master Apr 11, 2020
@Osspial Osspial mentioned this pull request Apr 20, 2020
Closed
@daxpedda daxpedda mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanisaacg ryanisaacg ryanisaacg approved these changes

Assignees
No one assigned
Labels
DS - web P - high Vital to have S - enhancement Wouldn't this be the coolest?
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chemicstry @ryanisaacg