Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify when RedrawRequested is useful #1529

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Clarify when RedrawRequested is useful #1529

merged 1 commit into from
Apr 19, 2020

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Apr 10, 2020

The current documentation's focus on traditional GUIs is an almost constant source of confusion among gamedevs.

Osspial
Osspial suggested changes Apr 19, 2020
View reviewed changes
Copy link
Contributor

@Osspial Osspial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer it if the comments were a little less assertive, since there's nothing wrong with rendering in RedrawRequested even if you're a game. Otherwise, this looks good. Thanks for pulling this together!

src/event.rs Outdated Show resolved Hide resolved
src/event.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@Ralith @Osspial
Clarify when RedrawRequested is useful
0dc096c 
Co-Authored-By: Osspial <osspial@gmail.com>
@Ralith
Copy link
Contributor Author

Ralith commented Apr 19, 2020

Works for me; suggestions applied.

@Osspial Osspial merged commit 849b8f5 into rust-windowing:master Apr 19, 2020
@ryanisaacg ryanisaacg mentioned this pull request Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Osspial Osspial Osspial requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ralith @Osspial