Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transparent window crash on Windows 11 #2121

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

yslib
Copy link
Contributor

@yslib yslib commented Jan 1, 2022

Maybe the transparent setting in WM_NCCREATE on Windows 11 will cause a block when callling DwmEnableBlureBehindWindow and will crash. Puts them into WM_CREATE and it works. #2082
I have not found any details about the behavior change on Windows 11. Perhaps it's could be a Win11 bug.
I have no win8 or earlier enviroment so I can't test them on these platforms.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

Maybe the transparent setting in WM_NCCREATE on Windows 11 will cause a block when calling DwmEnableBlureBehindWindow and will crash. Puts them into WM_CREATE and it works.
@maroider maroider added DS - windows C - waiting on maintainer A maintainer must review this code labels Jan 1, 2022
Copy link
Member

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tried on Win10 and works fine as well there.

@msiglreith
Copy link
Member

Could you add a changelog entry please?
Example

On Windows, fix a crash with transparent windows on Windows 11.

@msiglreith msiglreith mentioned this pull request Jan 2, 2022
3 tasks
@msiglreith msiglreith removed the C - waiting on maintainer A maintainer must review this code label Jan 2, 2022
Update CHANGELOG.md for Win11 transparent window issue
@yslib
Copy link
Contributor Author

yslib commented Jan 3, 2022

Could you add a changelog entry please? Example

On Windows, fix a crash with transparent windows on Windows 11.

Sorry for forgetting it. It was added.

@msiglreith msiglreith merged commit 25ff30e into rust-windowing:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants