-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WindowBuilderExtWebSys::with_prevent_default disables scrolling on both mobile and desktop (previously just desktop) #2216
Merged
madsmtm
merged 5 commits into
rust-windowing:master
from
rukai:improve_web_scroll_handling
Sep 4, 2022
Merged
WindowBuilderExtWebSys::with_prevent_default disables scrolling on both mobile and desktop (previously just desktop) #2216
madsmtm
merged 5 commits into
rust-windowing:master
from
rukai:improve_web_scroll_handling
Sep 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
improve_web_scroll_handling
branch
from
March 5, 2022 02:59
ff4dd96
to
bc5680f
Compare
maroider
added
DS - android
C - waiting on maintainer
A maintainer must review this code
labels
Mar 5, 2022
Hmmmm not sure how much it matters but should be tagged web not android |
madsmtm
reviewed
Apr 17, 2022
rukai
force-pushed
the
improve_web_scroll_handling
branch
from
April 23, 2022 23:49
bc5680f
to
dd254c5
Compare
rukai
force-pushed
the
improve_web_scroll_handling
branch
from
July 12, 2022 23:28
c4ef57f
to
5850030
Compare
rukai
force-pushed
the
improve_web_scroll_handling
branch
3 times, most recently
from
September 2, 2022 23:29
1038171
to
6ae6207
Compare
rukai
changed the title
Disable scrolling on web by default but provide method in builder to enable it
WindowBuilderExtWebSys::with_prevent_default disables scrolling on both mobile and desktop (previously just desktop)
Sep 3, 2022
rukai
force-pushed
the
improve_web_scroll_handling
branch
from
September 4, 2022 02:46
e635978
to
44fb436
Compare
madsmtm
approved these changes
Sep 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that looks good!
I modified the changlog entry to note it as a breaking change, while it doesn't change the API it changes the semantics. Will merge when CI finishes
13 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2116
CHANGELOG.md
if knowledge of this change could be valuable to usersTested on firefox on my desktop and firefox on my android phone.