Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep a reference to ApplicationDelegate in NSWindowDelegate and NSView #3684

Merged
merged 1 commit into from
May 6, 2024
Merged

Keep a reference to ApplicationDelegate in NSWindowDelegate and NSView #3684

merged 1 commit into from
May 6, 2024

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented May 5, 2024

The delegate is only weakly referenced by NSApplication, so getting it from there may fail if the event loop has been dropped.

Fixes #3668.

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@madsmtm madsmtm added DS - macos B - crash The bug results in crashing labels May 5, 2024
@madsmtm madsmtm mentioned this pull request May 5, 2024
Closed
kchibisov
kchibisov requested changes May 6, 2024
View reviewed changes
src/changelog/unreleased.md Outdated Show resolved Hide resolved
src/platform_impl/macos/app_delegate.rs Outdated Show resolved Hide resolved
src/platform_impl/macos/window_delegate.rs Show resolved Hide resolved
@kchibisov kchibisov added this to the Version 0.30.1 milestone May 6, 2024
@madsmtm @kchibisov
Retain ApplicationDelegate in NSWindowDelegate and NSView
d24be64 
The delegate is only weakly referenced by NSApplication, so getting it
from there may fail if the event loop has been dropped.

Fixes #3668.
@kchibisov kchibisov force-pushed the madsmtm/keep-delegate-around branch from d1a593c to d24be64 Compare May 6, 2024 14:21
@kchibisov kchibisov merged commit 0a3cacd into master May 6, 2024
52 checks passed
@kchibisov kchibisov deleted the madsmtm/keep-delegate-around branch May 6, 2024 14:29
@ArthurBrussee ArthurBrussee mentioned this pull request Jul 19, 2024
Closed
@emilk emilk mentioned this pull request Jul 19, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchibisov kchibisov kchibisov approved these changes

Assignees
No one assigned
Labels
B - crash The bug results in crashing DS - macos
Milestone
Version 0.30.1
Development

Successfully merging this pull request may close these issues.

winit 0.30 panics on exit on macOS
2 participants
@madsmtm @kchibisov